Certificate issues #514
Closed
Certificate issues #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdentityStore.addSelfSignedDomainCertificate considers the certificate validity in days, not in months.
|
Associated to https://igniterealtime.org/issues/browse/OF-1049 |
|
Thanks for your contribution. This should improve things a lot. I've added some comments inline. |
|
I'm merging this to master, cherry-picking all but the SHA-1 to SHA-2 commit to 4.0 branch. Will follow up to restore the 5-year validity for self-signed certificates. |
This was referenced Jan 25, 2016
|
I have created new pull requests that, combined, contain all of the commits from this pull request. #526 contains most commits, with an additional commit that restores the 5-year-validity for self-signed certificates. #527 contains the commit that replaces SHA-1 with SHA-2. Although desirable, we shouldn't have such a change in a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this work I did some things related to certificates: