OF-1049: Fixes for certificate management #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin console should existing-but-invalid configuration. Configuration should be modifiable through admin console.
Don't initialize the admin console TLS connector when no identity store is available (that's guaranteed to fail). Don't log admin console startup success when there's an error.
Check if the keys in the identity store can be accessed when the identity store is being created.
By reversing the order in which objects are added to the internal state, a failure during store construction won't put the manager in a half-initialized state.
guusdk
added a commit
that referenced
this pull request
Jan 25, 2016
OF-1049: Fixes for certificate management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds checks that prevent catastrophic failures when configuration is not as-expected. This allows, for example. the admin console to start up with a non-encrypted port only when TLS configuration is incorrect.
Also: added basic support for editing of certificate store management properties and improved error notification on th admin console.