Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-1408 Show the cache expiry time on the caches page #896

Merged
merged 2 commits into from Oct 19, 2017

Conversation

GregDThomas
Copy link
Contributor

This PR simply displays the cache expiry time (in milliseconds, if any) on the Cache Summary page.

image

@GregDThomas
Copy link
Contributor Author

A couple of things
a) joda-time has a nice PeriodFormat class which will prettily format a duration (e.g. 21600000 -> "6 hours", but it seems overkill to add yet another dependency just for this one page.
b) I've added an english entry to all the i18n files for the new column header - I'm not sure if that's strictly necessary - does it default to english if a country specific version is not present?

@akrherz
Copy link
Member

akrherz commented Oct 17, 2017

@GregDThomas Thanks, please consider opening Jira issues ahead of the PR so that your code change can be associated with an issue. Currently, the issue workflow is how we generate the changelog :/

@GregDThomas
Copy link
Contributor Author

Thanks - I hadn't realised I had JIRA creation rights. Now i do - raised at https://issues.igniterealtime.org/browse/OF-1408

@yuan24zz
Copy link

How to store online chat records into table ofoffline column “stanza” like offline chat

@guusdk
Copy link
Member

guusdk commented Oct 18, 2017

@yuan24zz Please do not comment on PRs with unrelated questions. Please ask your questions in https://discourse.igniterealtime.org/

@guusdk
Copy link
Member

guusdk commented Oct 18, 2017

This is a nice addition. I agree that adding a new library is overkill, but we might have something for this. Is something like this re-usable? https://github.com/igniterealtime/Openfire/blob/master/src/web/index.jsp#L211

@GregDThomas
Copy link
Contributor Author

StringUtils.getElapsedTime(long) is certainly a good starting point; I think I might need to create a new version, say StringUtils.getFullElapsedTime(long) , to make it more useful in this case as "Less than 1 minute" is perhaps less than ideal.

@guusdk
Copy link
Member

guusdk commented Oct 18, 2017

Whatever suits you - I'd not invest to much time though :)

@GregDThomas
Copy link
Contributor Author

Here you go - a definite improvement, IMHO.

image

@dwd dwd changed the title Show the cache expiry time on the caches page OF-1408 Show the cache expiry time on the caches page Oct 19, 2017
@dwd dwd merged commit 57944fa into igniterealtime:master Oct 19, 2017
@GregDThomas GregDThomas deleted the cache-expiry-time branch October 19, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants