SINT: Assert something when succeeding

It is good practice to require an explicit assertion for a test to
fail, but also for one to succeed. Although the test silently
succeeds when it does not fail, making this explicit describes
intent better.

This commit adds an explicit assertion to all tests in

- GeolocationIntegrationTest
- MoodIntegrationTest
- UserTuneIntegrationTest

smack-integration-test/src/main/java/org/jivesoftware/smackx/geolocation/GeolocationIntegrationTest.java

@@ -105,7 +105,10 @@ public void testNotification() throws Exception {
 
             // Wait for the data to be received.
             try {
-                geoLocationReceived.waitForResult(timeout);
+                Object result = geoLocationReceived.waitForResult(timeout);
+
+                // Explicitly assert the success case.
+                Assertions.assertNotNull(result, "Expected to receive a PEP notification, but did not.");
             } catch (TimeoutException e) {
                 Assertions.fail("Expected to receive a PEP notification, but did not.");
             }
@@ -165,7 +168,10 @@ public void testNotificationAfterFilterChange() throws Exception {
 
             // Wait for the data to be received.
             try {
-                geoLocationReceived.waitForResult(timeout);
+                Object result = geoLocationReceived.waitForResult(timeout);
+
+                // Explicitly assert the success case.
+                Assertions.assertNotNull(result, "Expected to receive a PEP notification, but did not.");
             } catch (TimeoutException e) {
                 Assertions.fail("Expected to receive a PEP notification, but did not.");
             }

smack-integration-test/src/main/java/org/jivesoftware/smackx/mood/MoodIntegrationTest.java

@@ -116,7 +116,10 @@ public void testNotificationAfterFilterChange() throws Exception {
 
             // Wait for the data to be received.
             try {
-                moodReceived.waitForResult(timeout);
+                Object result = moodReceived.waitForResult(timeout);
+
+                // Explicitly assert the success case.
+                Assertions.assertNotNull(result, "Expected to receive a PEP notification, but did not.");
             } catch (TimeoutException e) {
                 Assertions.fail("Expected to receive a PEP notification, but did not.");
             }

smack-integration-test/src/main/java/org/jivesoftware/smackx/usertune/UserTuneIntegrationTest.java

@@ -90,7 +90,10 @@ public void testNotification() throws Exception {
 
             // Wait for the data to be received.
             try {
-                userTuneReceived.waitForResult(timeout);
+                Object result = userTuneReceived.waitForResult(timeout);
+
+                // Explicitly assert the success case.
+                Assertions.assertNotNull(result, "Expected to receive a PEP notification, but did not.");
             } catch (TimeoutException e) {
                 Assertions.fail("Expected to receive a PEP notification, but did not.");
             }
@@ -136,7 +139,10 @@ public void testNotificationAfterFilterChange() throws Exception {
 
             // Wait for the data to be received.
             try {
-                userTuneReceived.waitForResult(timeout);
+                Object result = userTuneReceived.waitForResult(timeout);
+
+                // Explicitly assert the success case.
+                Assertions.assertNotNull(result, "Expected to receive a PEP notification, but did not.");
             } catch (TimeoutException e) {
                 Assertions.fail("Expected to receive a PEP notification, but did not.");
             }