[formtypes] Log warning on inconsistencies

igniterealtime · Feb 25, 2021 · a71d16a · a71d16a
1 parent 97a5cc7
commit a71d16a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/formtypes/FormFieldRegistry.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/formtypes/FormFieldRegistry.java
@@ -18,6 +18,7 @@
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.logging.Logger;
 
 import org.jivesoftware.smack.util.StringUtils;
 import org.jivesoftware.smack.util.XmlUtil;
@@ -27,6 +28,8 @@
 
 public class FormFieldRegistry {
 
+    private static final Logger LOGGER = Logger.getLogger(FormFieldRegistry.class.getName());
+
     private static final Map<String, Map<String, FormField.Type>> REGISTRY = new HashMap<>();
 
     private static final Map<String, String> FIELD_NAME_TO_FORM_TYPE = new HashMap<>();
@@ -69,7 +72,10 @@ public static synchronized void register(String formType, String fieldName, Form
                 throw new IllegalArgumentException();
             }
         }
-        fieldNameToType.put(fieldName, type);
+        FormField.Type previousType = fieldNameToType.put(fieldName, type);
+        if (previousType != null && type != previousType) {
+            LOGGER.warning("Form field registry inconsitency detected: Registered field '" + fieldName + "' of type " + type + " but previous type was " + previousType);
+        }
 
         FIELD_NAME_TO_FORM_TYPE.put(fieldName, formType);
     }