-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roomDestroyed to MUC UserStatusListener #34
Conversation
@@ -65,5 +65,8 @@ public void adminGranted() { | |||
|
|||
public void adminRevoked() { | |||
} | |||
|
|||
public void roomDestroyed(Jid alternateJID, String reason) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the parmater name alternateJID
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as here:
MultiUserChat.destroy(String reason, String alternateJID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, makes sense then. And I see it's javadoc'ed at the listener, so it's fine.
Thanks for you contribution. Please
|
Squashed the commits |
I've just pushed 516e397 Could you rebase you commit on it, so that we can get rid of the jid parsing code? |
Also please change
to
|
I will do it when I get home later. |
FYI, no need to close a PR. You could simply update the existing one by force-pushing to its source branch. |
I messed with the fork master and wanted a clean clone from the smack master without a "Merge commit". I rarely do other things than Push/Pull with git, still learning :) |
I could not test it yet, but it is pretty simple and looks ok to me.