Update HOXT API to use the builder pattern #50
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement the builder pattern for the HOXT API:
AbstractHttpOverXmpp
,HttpOverXmppReq
andHttpOverXmppResp
implement the builder pattern in the same style asConnectionConfiguration
andXMPPTCPConnectionConfiguration
.NullPointerException
issue. I updated so thatheaders
is given directly tooptAppend
butdata
does not extendElement
so it needs an extraif
.