-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make abstract package protected methods in PEPItem public #51
Conversation
Thanks for your contribution. Could you shorten the subject of the commit message so that it follows the 50/72 rule. E.g. "Make abstractpackage protected methods in PEPItem public". Also please mention the issue key "SMACK-372" somehwere in the commit messages body. |
@Flowdalic to shorten the git message shall I open a new pull request and close this one? |
No you can update existing PRs by just issuing a forced push to the source branch. |
@Flowdalic ammended the commit message. Thanks |
There is a missing space between "abstract" and "package". Also please don't put the issue key in the subject. Simply add Fixes SMACK-372 in the body. |
@Flowdalic Made changes as per review comments. Please review again. |
The issue key is still part of the subject. Cherry picked with minor modifications as 3bbffea |
@Flowdalic Wanted to confirm so that I do not goof up in future commits. Thanks |
SMACK-372 is the (JIRA) issue key. See also the commit message of 3bbffea |
Thanks! |
fixes SMACK-372