Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make abstract package protected methods in PEPItem public #51

Closed
wants to merge 1 commit into from

Conversation

rvaibhav
Copy link

fixes SMACK-372

@Flowdalic
Copy link
Member

Thanks for your contribution.

Could you shorten the subject of the commit message so that it follows the 50/72 rule. E.g. "Make abstractpackage protected methods in PEPItem public". Also please mention the issue key "SMACK-372" somehwere in the commit messages body.

@rvaibhav
Copy link
Author

@Flowdalic to shorten the git message shall I open a new pull request and close this one?

@Flowdalic
Copy link
Member

No you can update existing PRs by just issuing a forced push to the source branch.

@rvaibhav
Copy link
Author

@Flowdalic ammended the commit message.
Can you please review again.

Thanks

@rvaibhav rvaibhav changed the title Code changes to change package level access of abstract method to pub… Make abstractpackage protected methods in PEPItem public SMACK-372 Jul 31, 2015
@rvaibhav rvaibhav changed the title Make abstractpackage protected methods in PEPItem public SMACK-372 Make abstrac tpackage protected methods in PEPItem public SMACK-372 Jul 31, 2015
@rvaibhav rvaibhav changed the title Make abstrac tpackage protected methods in PEPItem public SMACK-372 Make abstract package protected methods in PEPItem public SMACK-372 Jul 31, 2015
@Flowdalic
Copy link
Member

There is a missing space between "abstract" and "package". Also please don't put the issue key in the subject. Simply add

Fixes SMACK-372

in the body.

@rvaibhav rvaibhav changed the title Make abstract package protected methods in PEPItem public SMACK-372 Fixes SMACK-372 Jul 31, 2015
@rvaibhav rvaibhav changed the title Fixes SMACK-372 Make abstract package protected methods in PEPItem public Jul 31, 2015
@rvaibhav
Copy link
Author

@Flowdalic Made changes as per review comments. Please review again.

@Flowdalic
Copy link
Member

The issue key is still part of the subject. Cherry picked with minor modifications as 3bbffea

@Flowdalic Flowdalic closed this Jul 31, 2015
@rvaibhav
Copy link
Author

@Flowdalic
Issue key is "Make abstract package protected methods in PEPItem public"
or "SMACK-372"?

Wanted to confirm so that I do not goof up in future commits.

Thanks
Vaibhav

@Flowdalic
Copy link
Member

SMACK-372 is the (JIRA) issue key. See also the commit message of 3bbffea

@rvaibhav rvaibhav deleted the smack372 branch July 31, 2015 12:53
@rvaibhav
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants