Sint tagging #579
Merged
Sint tagging #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
sint_tagging
branch
2 times, most recently
from
9589b52
to
dd41486
Compare
guusdk
force-pushed
the
sint_tagging
branch
3 times, most recently
from
e50908c
to
0ac2b8a
Compare
Flowdalic
requested changes
Mar 19, 2024
...-test/src/main/java/org/igniterealtime/smack/inttest/annotations/SpecificationReference.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smackx/caps/EntityCapsTest.java
Outdated
Show resolved
Hide resolved
Flowdalic
requested changes
Apr 5, 2024
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
|
I believe I've processed all review comments. |
Flowdalic
requested changes
Apr 9, 2024
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
A new annotation is introduced (`SpecificationReference`) that can be used to annotate a SINT test class The properties are available in the annotation: - `document`: Identifier for a specification document, such as 'RFC 6120' or 'XEP-0485' The pre-existing `SmackIntegrationTest` annotation has now received two new properties: - `section`: Identifier for a section (or paragraph), such as '6.2.1' - `quote`: A quotation of relevant text from the section These are expected to be used in context of the `SpecificationReference` annotation. The SINT execution framework is modified so that two new configuration options are available: - `enabledSpecifications` - `disabledSpecifications` These operate on the value of the `document` property of the annotation. Their usage is comparable to that of the pre-existing `enabledTests` and `disabledTest` configuration options. Execution output now includes the document, section and quote that's on the annotated test, when the test fails. This allows an end-user to easily correspond a test failure with a particular specification.
This applies the new features from the previous commit, and applies them to pre-existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new annotation is introduced (
SpecificationReference) that can be used to annotate a SINT test.These properties are available in the annotation:
document: Iidentifier for a specification document, such as 'RFC 6120' or 'XEP-0485'section: Identifier for a section (or paragraph), such as '6.2.1'quote: A quotation of relevant text from the sectionThe SINT execution framework is modified so that two new configuration options are available:
enabledSpecificationsdisabledSpecificationsThese operate on the value of the
documentproperty of the annotation. Their usage is comparableto that of the pre-existing
enabledTestsanddisabledTestconfiguration options.Execution output now includes the document, section and quote that's on the annotated test, when
the test fails. This allows an end-user to easily correspond a test failure with a particular
specification.