-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[muc] changeSubject errors should be propagated #596
Conversation
When Smack requests a subject change of a MUC, an error returned by the server (eg: 'forbidden') should be propagated (as suggested by the pre-existing javadoc).
This fixes the problem reported in https://discourse.igniterealtime.org/t/multiuserchat-changesubject-times-out-without-auth/ |
LGTM But could you change the type of the argument of the |
I tried, but apparently the ID is not set yet without building the stanza. |
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implemetation. See igniterealtime/Smack#596
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
Fixed with 147071f |
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
When Smack requests a subject change of a MUC, an error returned by the server (eg: 'forbidden') should be propagated (as suggested by the pre-existing javadoc).