Uses voice as default number detail, if no type is available. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
referenced
this pull request
in jitsi/smack_3_2_2
Dec 6, 2015
|
Thanks for you contribution. The added comment doesn't state what the behavior the change really introduces: It will set the label to But the motivation behind the change seems legit, since RFC 2426 § 3.3.1 clearly states
Please note that Smack's vcard-temp code is terrible. I always wanted to fix it completely, but I guess it's better to do little steps into the right direction for now. :) |
|
Cherry picked with minor modifications as db72917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.