Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to handle roster packet errors. #61

Closed
wants to merge 3 commits into from
Closed

Update to handle roster packet errors. #61

wants to merge 3 commits into from

Conversation

damencho
Copy link
Contributor

@damencho damencho commented Dec 6, 2015

No description provided.

damencho referenced this pull request in jitsi/smack_3_2_2 Dec 6, 2015
@damencho
Updates smack to handle roster packet errors.
f5f21c5
@Flowdalic
Copy link
Member

Thanks for your contribution. Could you

  • squash the commits?
  • provide a better commit message? e.g. "Add a Roster callback for error Presences"

@Flowdalic
Copy link
Member

Uh, and I just noticed that it won't work this way. You want to hook into the ExceptionCallback which is installed together with RosterResultListener to listen for error IQ responses. I guess in the end we want a callback for this, and not only for error IQ responses.

@damencho damencho closed this Dec 6, 2015
@damencho damencho deleted the handle-roster-errors branch December 6, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@damencho @Flowdalic