Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nick.java #78

Closed
wants to merge 1 commit into from
Closed

Update Nick.java #78

wants to merge 1 commit into from

Conversation

UltimateZero
Copy link
Contributor

Use empty string in case of an empty element tag.

@Flowdalic
Copy link
Member

Thanks. Could you go with the slightly more optimized approach of

String name;
if (parser.isEmptyElement()) {
  name = "";
} else {
  name = parser.getText();
}

then squash your commits into a single commit and update this PR by performing a force push.

@Flowdalic
Copy link
Member

Perfect! Now please squash.

@UltimateZero
Copy link
Contributor Author

@Flowdalic Hi, I am not sure if you got a notification or not, but I have squashed the commits. Anything else missing?

@Flowdalic
Copy link
Member

I was just about to cherry-pick this (In fact I already did) when I realized that the real fix is

-            parser.next();
-           final String name = parser.getText();
+            final String name = parser.nextText();

Feel free to update the PR according to this. If not, then please let me know so that I can commit it myself.

It will use an empty string in case of an empty element tag.
@UltimateZero
Copy link
Contributor Author

Ah I didn't know that existed, I was just following the old code.
Ok done and squashed into one commit.

@Flowdalic
Copy link
Member

Flowdalic commented May 31, 2016

Closed via df0f805. Thanks for your contribution.

@Flowdalic Flowdalic closed this May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants