Multi-User Chat Light (v0.1.0) implementation #81

ramabit · 2016-05-30T17:18:36Z

Multi-User Chat Light (v0.1.0) documentation: http://mongooseim.readthedocs.io/en/latest/open-extensions/xeps/xep-muc-light.html

All modules are implemented :)

Flowdalic · 2016-05-31T06:17:46Z

Thanks for your contribution. I will work the PRs in FIFO order. But I already noticed that you placed this in smack-extensions while it should be in smack-experimental.

ramabit · 2016-06-03T14:52:15Z

@Flowdalic Everything moved to smack-experimental

ramabit · 2016-06-14T20:16:00Z

@Flowdalic In the following days I will be updating this PR implementing the missing functionalities until MUC Light be fully implemented

ramabit · 2016-06-27T19:50:41Z

@Flowdalic now the MUC Light implementation is complete

ramabit · 2016-07-14T17:56:32Z

Detailed documentation added: documentation/extensions/muclight.md

Flowdalic · 2016-07-23T13:59:54Z

documentation/extensions/index.md

@@ -85,6 +85,7 @@ Experimental Smack Extensions and currently supported XEPs of smack-experimental
 | [Internet of Things - Discovery](iot.md)    | [XEP-0347](http://xmpp.org/extensions/xep-0347.html) | Describes how Things can be installed and discovered by their owners. |
 | Google GCM JSON payload                     | n/a                                                  | Semantically the same as XEP-0335: JSON Containers |
 | Client State Indication                     | [XEP-0352](http://xmpp.org/extensions/xep-0352.html) | A way for the client to indicate its active/inactive state. |
+| Multi-User Chat Light                       | [XEP-xxxx]( https://s3.amazonaws.com/uploads.hipchat.com/15025/1268415/d9ByVbihpLmzxBI/XEP-xxxx.Multi.User.Chat.Light.pdf) | Multi-User Chats for mobile XMPP applications and specific enviroment. |


Can't this point to the XSF's inbox/? Or some other official place where MUC light is provided?

I am investigating that

Flowdalic · 2016-07-23T14:10:30Z

Needs conflict resolution

Flowdalic · 2016-07-28T07:05:42Z

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java

+        } catch (NoResponseException | XMPPErrorException e) {
+            removeConnectionCallbacks();
+            return false;
+        } catch (InterruptedException e) {


Why isn't this part of the multi-catch above?

Flowdalic · 2016-07-28T07:13:19Z

...k-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLightManager.java

+                .discoverItems(connection().getServiceName());
+        boolean found = false;
+        for (DiscoverItems.Item item : discoverItems.getItems()) {
+            if (item.getEntityID().equals(mucLightService)) {


I'm sorry, but what are you doing here?

@Flowdalic Checking if the service received as a parameter is supported by the server (retrieved in discover items)

That's not very helpful, please remove this method. If you already have a DomainBareJid then you could just perform a disco#info on it and determine if it announces the muc-light feature. A method

public DomainBareJid discoverService()

which returns the DomainBareJid of the local muc-light service or null if none was found, would be of much more useful.

@Flowdalic That method you mention is already implemented too:
public List<DomainBareJid> getXMPPServiceDomains()
Should I remove the method isServiceEnabled anyway?

Ahh good point, then simply remove it.

Also I suggest to

s/isFeatureSupportedByServer(DomainBareJid)/isFeatureSupported(DomainBareJid)/

s/getXMPPServiceDomains()/getLocalServices()/

Flowdalic · 2016-07-28T07:17:14Z

I've made a few comments. Please address the issues and append new commits, so it's easier to track which and how they are fixed. I'll tell you when it's time for another round of squashing.

ramabit · 2016-07-29T13:43:58Z

@Flowdalic Fixes done
The XSF's inbox/ has a previous version (https://xmpp.org/extensions/inbox/muc-light.html v0.0.1). I implemented the v0.1.0. I am trying to upload that XEP somewhere

Flowdalic · 2016-07-29T13:54:05Z

The XSF's inbox/ has a previous version (https://xmpp.org/extensions/inbox/muc-light.html v0.0.1). I implemented the v0.1.0. I am trying to upload that XEP somewhere

Well that somewhere somehow scares me. I mean there must be someone feeling responsible for the MUC light development, even if it was not accepted as experimental XEP by the XSF. And that person/entity should make the current state of the XEP official available in some canonical way (and not e.g. an S3 upload).

ramabit · 2016-07-29T14:12:27Z

Well that somewhere somehow scares me. I mean there must be someone feeling responsible for the MUC light development, even if it was not accepted as experimental XEP by the XSF. And that person/entity should make the current state of the XEP official available in some canonical way (and not e.g. an S3 upload).

@Flowdalic I work for the same company as the responsible of the XEP and we are trying to host it

ramabit · 2016-07-29T15:19:28Z

@Flowdalic MUC Light XEP hosted ^

Flowdalic · 2016-11-01T08:34:47Z

It appears that this PR does not yet register a single provider for MUC light. Please change that.

ramabit · 2016-11-01T15:43:50Z

@Flowdalic Yes, they are registered. Check the diff https://github.com/igniterealtime/Smack/pull/81/files#diff-f533fc3c1cd8e007931dcaca4282b8ff

Flowdalic · 2016-11-02T08:15:45Z

Ahh, right sorry. Squash pls, then it's ready to merge. I'm a little bit worried regarding code duplication with the MUC codebase, but I guess that's fine for now (and probably for the future).

ramabit · 2016-11-02T15:13:35Z

@Flowdalic Squash done

Flowdalic · 2016-11-15T21:40:12Z

Cherry picked as 5372c1b
Assigned SMACK-740

Thanks! :)

ramabit changed the title ~~Ramabit.muclight~~ Multi-User Chat Light (v0.1.0) implementation May 30, 2016

ramabit force-pushed the ramabit.muclight branch from 4ace558 to 9e5e350 Compare May 30, 2016 19:01

ramabit force-pushed the ramabit.muclight branch 3 times, most recently from cc30088 to be195c9 Compare June 8, 2016 18:31

ramabit force-pushed the ramabit.muclight branch 3 times, most recently from 3355664 to 80327e5 Compare June 27, 2016 19:40

ramabit force-pushed the ramabit.muclight branch from e29f73d to 9da4a48 Compare July 14, 2016 17:42

ramabit force-pushed the ramabit.muclight branch from 9da4a48 to bb21be9 Compare July 15, 2016 14:18

ramabit closed this Jul 22, 2016

ramabit force-pushed the ramabit.muclight branch from 709208d to d1fe5c2 Compare July 22, 2016 14:02

ramabit reopened this Jul 22, 2016

ramabit force-pushed the ramabit.muclight branch from a9c21fd to b94bbea Compare July 22, 2016 17:21

Flowdalic reviewed Jul 23, 2016
View reviewed changes

ramabit force-pushed the ramabit.muclight branch from b94bbea to f161063 Compare July 27, 2016 18:12

Flowdalic reviewed Jul 28, 2016
View reviewed changes

ramabit force-pushed the ramabit.muclight branch from 6df11d9 to 0c590db Compare September 16, 2016 18:07

ramabit closed this Oct 31, 2016

ramabit reopened this Oct 31, 2016

ramabit force-pushed the ramabit.muclight branch from c006f31 to 5fa5a95 Compare November 1, 2016 20:24

Multi-User Chat Light implementation

12c604d

ramabit force-pushed the ramabit.muclight branch from 5fa5a95 to 12c604d Compare November 2, 2016 15:12

ramabit closed this Nov 7, 2016

ramabit reopened this Nov 7, 2016

Flowdalic closed this Nov 15, 2016

ramabit deleted the ramabit.muclight branch November 17, 2016 19:02

jonathanve mentioned this pull request Feb 17, 2017

MongooseIM 2.0.1 esl/MongooseIM#1164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-User Chat Light (v0.1.0) implementation #81

Multi-User Chat Light (v0.1.0) implementation #81

ramabit commented May 30, 2016 •

edited

Loading

Flowdalic commented May 31, 2016

ramabit commented Jun 3, 2016

ramabit commented Jun 14, 2016 •

edited

Loading

ramabit commented Jun 27, 2016

ramabit commented Jul 14, 2016

Flowdalic Jul 23, 2016

ramabit Jul 27, 2016

Flowdalic commented Jul 23, 2016

Flowdalic Jul 28, 2016

ramabit Jul 28, 2016

Flowdalic Jul 28, 2016

ramabit Jul 28, 2016

Flowdalic Jul 30, 2016 •

edited

Loading

ramabit Aug 1, 2016 •

edited

Loading

Flowdalic Aug 2, 2016

ramabit Aug 2, 2016

Flowdalic commented Jul 28, 2016

ramabit commented Jul 29, 2016

Flowdalic commented Jul 29, 2016

ramabit commented Jul 29, 2016

ramabit commented Jul 29, 2016

Flowdalic commented Nov 1, 2016

ramabit commented Nov 1, 2016

Flowdalic commented Nov 2, 2016

ramabit commented Nov 2, 2016

Flowdalic commented Nov 15, 2016

Multi-User Chat Light (v0.1.0) implementation #81

Multi-User Chat Light (v0.1.0) implementation #81

Conversation

ramabit commented May 30, 2016 • edited Loading

Flowdalic commented May 31, 2016

ramabit commented Jun 3, 2016

ramabit commented Jun 14, 2016 • edited Loading

ramabit commented Jun 27, 2016

ramabit commented Jul 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flowdalic commented Jul 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flowdalic Jul 30, 2016 • edited Loading

Choose a reason for hiding this comment

ramabit Aug 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flowdalic commented Jul 28, 2016

ramabit commented Jul 29, 2016

Flowdalic commented Jul 29, 2016

ramabit commented Jul 29, 2016

ramabit commented Jul 29, 2016

Flowdalic commented Nov 1, 2016

ramabit commented Nov 1, 2016

Flowdalic commented Nov 2, 2016

ramabit commented Nov 2, 2016

Flowdalic commented Nov 15, 2016

ramabit commented May 30, 2016 •

edited

Loading

ramabit commented Jun 14, 2016 •

edited

Loading

Flowdalic Jul 30, 2016 •

edited

Loading

ramabit Aug 1, 2016 •

edited

Loading