New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARK-1989 create empty KeyStores #376
Conversation
e46d3cd
to
20666af
Compare
20666af
to
99c5cca
Compare
What does it mean that user opens advanced panel? What if a user doesn't ever open it and just hits login on a fresh profile? |
Then KeyStores are opened if exist, if not new empty KeyStores are created because TrustManagers/KeyManager need them but I don't save them. Anyway if there were no KeyStores then user shouldn't be able to connect until he add required certificates (and by that open advanced panel). |
The usual user-friendly model is that if an unknown/self-signed certificate is encountered, the app provides a dialog/popup with an immediate option to add this certificate to an exception list or do a one time login. A number of clients i have used do this, browsers do this. It can involve a few steps, but a user shouldn't be looking for a menu to add a certificate to exceptions. A list of default certificates won't solve this. |
I agree, that is thing I should to add. I will work on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of boilerplate code here. There are fragments of code, that are pretty much duplicates, but use different variables. Let's replace those with a method.
The popup is certainly desirable, but not part of the GSoC project. Let's focus on finishing that first. We'll create the pop-up directly afterwards. |
Thanks :) |
New empty KeyStores are created each time when user open advanced panel and there are no existing KeyStores in user directory already.