Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostame or version as resource to plugin settings #8

Closed
wrooot opened this issue Feb 10, 2019 · 4 comments
Closed

Add hostame or version as resource to plugin settings #8

wrooot opened this issue Feb 10, 2019 · 4 comments

Comments

@wrooot
Copy link
Contributor

wrooot commented Feb 10, 2019

Spark already have Hostname as Resources and Version as Resource settings in default.properties file, so one can hardcode this. But it would be more convenient for admins to set these settings via Admin Console.

As only one can be true, currently Hostname is used when both settings have value "true". Ideally one of the settings in the list should get disabled when another is selected. Though it might be harder for me to implement (for now a note in description should work).

@wrooot
Copy link
Contributor Author

wrooot commented Feb 10, 2019

On Spark end it is implemented via https://issues.igniterealtime.org/browse/SPARK-2086

wrooot added a commit that referenced this issue Feb 10, 2019
@wrooot
Copy link
Contributor Author

wrooot commented Feb 10, 2019

I've messed up while trying to clean my history and commited directly to ignite repo instead of my fork. Wanted first to show my PR to someone, but, whatever.

There is a small issue though. Two added settings are not changing on a first save. One have to change setting and press Save again for them to stick. Probably related to my wish to make them disabled by default. First of all they won't work along and also some users might want to have their custom resources and this will change if admin updates Client Control plugin.

@wrooot
Copy link
Contributor Author

wrooot commented Feb 10, 2019

Another nice to have option would be to disable one option, when another is set to Enabled (as they can't be both enabled).

@wrooot
Copy link
Contributor Author

wrooot commented Mar 11, 2019

Have decided to make these settings enabled by default (this way saving them works fine). Probably not a big deal that both will be enabled and Hostname will be used as a resource once admins update the plugin. Leaving it for someone else to figure out how to make them disabled by default or how to block one when another is enabled.

wrooot added a commit that referenced this issue Mar 11, 2019
 #8 change to enabled by default
@wrooot wrooot closed this as completed Mar 11, 2019
akrherz pushed a commit to akrherz/openfire-clientControl-plugin that referenced this issue Oct 30, 2020
akrherz pushed a commit to akrherz/openfire-clientControl-plugin that referenced this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant