Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect IQ query responses for external components #3

Closed
guusdk opened this issue Jan 16, 2023 · 0 comments
Closed

Incorrect IQ query responses for external components #3

guusdk opened this issue Jan 16, 2023 · 0 comments

Comments

@guusdk
Copy link
Member

guusdk commented Jan 16, 2023

Agent information obtained from external components seems to fail: they contain nothing but the JID of the agent.

On closer inspection, it appears that the responses to disco#info requests made to external components are registered as an item-not-found error, even though the component themselves will properly answer such requests.

The querying mechanism needs work.

(issue copied from: igniterealtime/openfire-agentinformation-plugin#3 )
guusdk added a commit to guusdk/openfire-jabberbrowsing-plugin that referenced this issue Jan 16, 2023
@guusdk
fixes igniterealtime#3: Service Discovery on External Components failed
466ae62 
The implementation queries for disco#info and disco#items, to base it's jabberbrowsing responses on. The disco#info/item requests that were performed by the plugin were implemented using a shortcut that is only valid for _internal_ components.

This commit ensures that when discovering information of external components, a full XMPP request is performed.
@guusdk guusdk closed this as completed in 6d5b5eb Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guusdk