Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The monitoring plugin removes carriage returns (\n) in text body #36

Closed
deleolajide opened this issue Apr 13, 2019 · 2 comments
Closed

The monitoring plugin removes carriage returns (\n) in text body #36

deleolajide opened this issue Apr 13, 2019 · 2 comments

Comments

@deleolajide
Copy link
Member

When a message is formatted as a multi-line string with carriage return "\n" characters, it is saved correctly in the DB, but monitoring plugin removes the "\u000a" in the body of the archived message stanza created.

<message from="test@conference.desktop-545pc5b/Dele Olajide" id="e0678c1b-fa3d-421b-a5b3-5b39d4a8b149" to="dele@desktop-545pc5b/pade-converse-v4.2.0-Chrome73Win10.64-26059867" type="groupchat">
  <body>Your heading goes here ======================</body>
  <active xmlns="http://jabber.org/protocol/chatstates"></active>
  <origin-id xmlns="urn:xmpp:sid:0" id="e0678c1b-fa3d-421b-a5b3-5b39d4a8b149"></origin-id>
  <stanza-id xmlns="urn:xmpp:sid:0" id="e0678c1b-fa3d-421b-a5b3-5b39d4a8b149" by="test@conference.desktop-545pc5b"/>
</message>

This causes markdown text to be formatted incorrectly
@deleolajide deleolajide mentioned this issue Apr 13, 2019
Closed
@guusdk
Copy link
Member

guusdk commented Jun 25, 2019

This is caused by https://issues.igniterealtime.org/browse/OF-1804

guusdk added a commit to guusdk/Openfire that referenced this issue Jun 25, 2019
@guusdk
OF-1804: Retain original formatting when logging messages
687469e 
toString() applies a pretty print formatter, which mangles the formatting of message text. This introduces igniterealtime/openfire-monitoring-plugin#36
@guusdk guusdk mentioned this issue Jun 25, 2019
Merged
guusdk added a commit to guusdk/openfire-monitoring-plugin that referenced this issue Jun 25, 2019
@guusdk
igniterealtime#36: fixes newlines (OF-1804 workaround).
d2e496a
guusdk added a commit that referenced this issue Jun 25, 2019
@guusdk
#36: fixes newlines (OF-1804 workaround).
c05ae41
@guusdk
Copy link
Member

guusdk commented Jun 25, 2019

Fixed in 1.8.0.

@guusdk guusdk closed this as completed Jun 25, 2019
akrherz pushed a commit to igniterealtime/Openfire that referenced this issue Jun 28, 2019
@guusdk @akrherz
OF-1804: Retain original formatting when logging messages
78a1f0d 
toString() applies a pretty print formatter, which mangles the formatting of message text. This introduces igniterealtime/openfire-monitoring-plugin#36
@guusdk guusdk mentioned this issue Nov 22, 2019
Closed
guusdk added a commit to guusdk/openfire-monitoring-plugin that referenced this issue Nov 22, 2019
@guusdk
fix igniterealtime#46: Replace body text with properly escaped data
143fdda 
The fix for igniterealtime#36 replaces the text value of the body element with other text. The replacement text needs to be properly escaped for XML.
@guusdk guusdk mentioned this issue Nov 22, 2019
Merged
guusdk added a commit that referenced this issue Dec 2, 2019
@guusdk
fix #46: Replace body text with properly escaped data
54f390e 
The fix for #36 replaces the text value of the body element with other text. The replacement text needs to be properly escaped for XML.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
@guusdk @akrherz
igniterealtime#36: fixes newlines (OF-1804 workaround).
54d172e
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
@guusdk @akrherz
fix igniterealtime#46: Replace body text with properly escaped data
df3a39f 
The fix for igniterealtime#36 replaces the text value of the body element with other text. The replacement text needs to be properly escaped for XML.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
@GregDThomas @akrherz
Remove some code that was used to maintain backward compatibility. (i…
a50a7e1 
…gniterealtime#36)

As a side effect improve ClusteredCacheFactory
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
@guusdk @akrherz
igniterealtime#36: fixes newlines (OF-1804 workaround).
4c8f04f
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
@guusdk @akrherz
fix igniterealtime#46: Replace body text with properly escaped data
50b6686 
The fix for igniterealtime#36 replaces the text value of the body element with other text. The replacement text needs to be properly escaped for XML.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Dec 1, 2020
@guusdk @akrherz
igniterealtime#36: fixes newlines (OF-1804 workaround).
46f4f32
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Dec 1, 2020
@guusdk @akrherz
fix igniterealtime#46: Replace body text with properly escaped data
54be3b8 
The fix for igniterealtime#36 replaces the text value of the body element with other text. The replacement text needs to be properly escaped for XML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deleolajide @guusdk