Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#195 Updated plugin for compatibility with OF 4.7.0 #197

Merged

Conversation

evdherberg
Copy link

See #195 for details.

@guusdk
Copy link
Member

guusdk commented Oct 27, 2021

Before we release a plugin, we should update the dependency in the pom.xml to a non-snapshot of Openfire 4.7.0 (which currently is not available yet).

@guusdk
Copy link
Member

guusdk commented Oct 27, 2021

Does this change mean that the resulting plugin is no longer compatible with versions of Openfire prior to version 4.7.0? If so, we should update the value of <minServerVersion>4.4.0</minServerVersion> in plugin.xml to 4.7.0.

@evdherberg
Copy link
Author

Does this change mean that the resulting plugin is no longer compatible with versions of Openfire prior to version 4.7.0? If so, we should update the value of <minServerVersion>4.4.0</minServerVersion> in plugin.xml to 4.7.0.

I think it does mean that. Let me take care of that.

@guusdk
Copy link
Member

guusdk commented Oct 27, 2021

@akrherz is the Github Actions build failing similar to the issue that we've seen before? And if it is, does that mean it'll affect all plugins?

Emiel van der Herberg added 2 commits October 27, 2021 09:06
… is not backward compatible. Interface changed.
@akrherz akrherz force-pushed the 195-fix-incompatibleclasschangeerror branch from ac89e51 to 4d4b46f Compare October 27, 2021 14:07
@akrherz
Copy link
Member

akrherz commented Oct 27, 2021

Attempted to rebase this with my CI fix in place.

@guusdk
Copy link
Member

guusdk commented Oct 27, 2021

CI seems happy!

@guusdk guusdk merged commit ff1661a into igniterealtime:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants