Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JvbPluginWrapper.java #108

Merged
merged 1 commit into from Nov 29, 2020
Merged

Conversation

gjaekel
Copy link
Contributor

@gjaekel gjaekel commented Nov 28, 2020

Along with domain, make port of public URL of colibri-ws announced to the client configurable.

Probably fixes #101 .

Along with domain, make port of public URL of colibri-ws announced to the *client* configurable.
@gjaekel
Copy link
Contributor Author

gjaekel commented Nov 28, 2020

This should fix my problem: I simulate it by editing the generated application.conf (replace the port 7443by 443) and set it read-only. After a restart, the exceptions at the clients vanished.

@deleolajide deleolajide merged commit e9523c0 into igniterealtime:master Nov 29, 2020
@gjaekel gjaekel deleted the patch-14 branch November 30, 2020 08:51
@deleolajide
Copy link
Member

image

Refreshed jar files

@gjaekel
Copy link
Contributor Author

gjaekel commented Nov 30, 2020

Thank you for also for propper GUI-Integration. But maybe the explanation should be changed, too: Because it's not configurable (at least for now), the use of websockets for Colibri is requested for the client by the config.js and therefore it's mandatory at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug or misconfiguration of colibri-ws Proxy?
2 participants