fix #9: 'text' type requests should not return null #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'text' type request returns the last known 'status' (not 'show'). It's a bit dodgy that this takes the last known status when a user is offline (where other endpoints return a 'current' status). This behavior is not changed in this commit (warrants further investigation - it is cleary implemented intentionally). When the status is absent, this endpoint returns a value `null`. The status is an optional element, not set by all clients. It is undesirable to have a 'null' value. This commit replaces it with an hardcoded value of 'Available', matching the implementation that hardcodedly sets 'Unavailable' for clients that are offline _and_ do not have a 'last known' presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'text' type request returns the last known 'status' (not 'show'). It's a bit dodgy that this takes the last known status when a user is offline (where other endpoints return a 'current' status). This behavior is not changed in this commit (warrants further investigation - it is cleary implemented intentionally).
When the status is absent, this endpoint returns a value
null. The status is an optional element, not set by all clients. It is undesirable to have a 'null' value. This commit replaces it with an hardcoded value of 'Available', matching the implementation that hardcodedly sets 'Unavailable' for clients that are offline and do not have a 'last known' presence.