Properly process requests that have invalid MUC service or room references #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
74_MUC-related-NPEs
branch
from
49ab902
to
b6e1a59
Compare
|
Worth a couple of unit tests to prove and retain the behaviour? |
…ences When requests are made against MUC services or rooms that do not exist (but are expected to), then the old implementation would return a HTTP 500 "Internal Server Error" response. This commit explicitly checks if the MUC service/room that is used in the request exist, and return HTTP 404 "Not Found" when that's not the case. I've also included more annotations that will cause Swagger to generate a more complete list of errors that are returned for MUC services. this fixes igniterealtime#74
guusdk
force-pushed
the
74_MUC-related-NPEs
branch
from
b6e1a59
to
023d887
Compare
I briefly looked at that, but that might not be very easy or representative. In the current setup, we'd basically replace the thing that generates the tests now with a mock, which kind of defeats the purpose of the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requests are made against MUC services or rooms that do not exist (but are expected to), then the old implementation would return a HTTP 500 "Internal Server Error" response.
This commit explicitly checks if the MUC service/room that is used in the request exist, and return HTTP 404 "Not Found" when that's not the case.
I've also included more annotations that will cause Swagger to generate a more complete list of errors that are returned for MUC services.
this fixes #74