Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Sourcery refactored main branch #1

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Sourcery refactored main branch #1

merged 5 commits into from
Mar 15, 2022

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Mar 15, 2022

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from cesarcoatl March 15, 2022 21:33
src/java/util/__init__.py Outdated Show resolved Hide resolved
return "<html><head>{}</head><body>data</body></html>".format(title)
return f"<html><head>{title}</head><body>data</body></html>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function dataSetToHTML refactored with the following changes:

src/system/file.py Outdated Show resolved Hide resolved
label = JLabel("{}: ".format(message))
label = JLabel(f"{message}: ")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function inputBox refactored with the following changes:

src/system/sfc.py Outdated Show resolved Hide resolved
src/system/util.py Show resolved Hide resolved
src/system/util.py Outdated Show resolved Hide resolved
@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Mar 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 0.79 ⭐ 0.79 ⭐ 0.00
Method Length 15.92 ⭐ 15.87 ⭐ -0.05 👍
Working memory 4.23 ⭐ 4.23 ⭐ 0.00
Quality 92.13% 92.16% 0.03% 👍
Other metrics Before After Change
Lines 826 826 0
Changed files Quality Before Quality After Quality Change
src/system/util.py 92.13% ⭐ 92.16% ⭐ 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/system/util.py getProperty 7 ⭐ 73 🙂 11 😞 64.11% 🙂 Extract out complex expressions
src/system/util.py queryAuditLog 0 ⭐ 36 ⭐ 10 😞 78.76% ⭐ Extract out complex expressions
src/system/util.py sendMessage 0 ⭐ 35 ⭐ 10 😞 78.92% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@cesarcoatl cesarcoatl merged commit b32da16 into main Mar 15, 2022
@cesarcoatl cesarcoatl deleted the sourcery/main branch March 15, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant