Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system): add db constants to __all__ #36

Merged
merged 1 commit into from
Jul 25, 2022
Merged

feat(system): add db constants to __all__ #36

merged 1 commit into from
Jul 25, 2022

Conversation

cesarcoatl
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When running mypy we get errors saying the db module does not have BIT, for example.

Issue Number: #34

What is the new behavior?

Adding the constants to __all__ will fix the error reported in #34.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 25, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.13%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 22.24 ⭐ 23.66 ⭐ 1.42 👎
Working memory 3.66 ⭐ 3.66 ⭐ 0.00
Quality 87.92% 86.79% -1.13% 👎
Other metrics Before After Change
Lines 763 804 41
Changed files Quality Before Quality After Quality Change
src/system/db.py 87.92% ⭐ 86.79% ⭐ -1.13% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/system/db.py addDatasource 0 ⭐ 41 ⭐ 12 😞 74.31% 🙂 Extract out complex expressions
src/system/db.py runPrepUpdate 0 ⭐ 31 ⭐ 10 😞 79.58% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@cesarcoatl cesarcoatl merged commit f4965ba into ignition-api:main Jul 25, 2022
@cesarcoatl cesarcoatl deleted the feat/system/db-all branch July 25, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant