Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃弫 Blueprint EOL #369

Merged
merged 3 commits into from
Jan 5, 2021
Merged

馃弫 Blueprint EOL #369

merged 3 commits into from
Jan 5, 2021

Conversation

chapulina
Copy link
Contributor

Do not merge until January 1st 2021.

Library versions EOLing with Blueprint:

  • ign-fuel-tools3
  • ign-gazebo2
  • ign-gui2
  • ign-launch1
  • ign-msgs4
  • ign-physics1
  • ign-rendering2
  • ign-sensors2
  • ign-transport7
  • ign-tools0
  • sdf8

I also removed some versions that had long been EOL, because they're not used by any Ignition or classic versions:

  • ign-cmake1
  • ign-common2
  • ign-fuel-tools2
  • ign-math5
  • ign-msgs2
  • ign-transport5

Also, not sure why it wasn't there, but added ign-transport2, which is used by Gazebo 7 (to EOL in 1 month)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@scpeters
Copy link
Contributor

scpeters commented Jan 1, 2021

I think we can disable CI for sdformat8 as well:

diff --git a/jenkins-scripts/dsl/sdformat.dsl b/jenkins-scripts/dsl/sdformat.dsl
index e8a81ed0..f6681663 100644
--- a/jenkins-scripts/dsl/sdformat.dsl
+++ b/jenkins-scripts/dsl/sdformat.dsl
@@ -1,8 +1,8 @@
 import _configs_.*
 import javaposse.jobdsl.dsl.Job
 
-def sdformat_supported_branches = [ 'sdformat4', 'sdformat6', 'sdformat8' , 'sdformat9', 'sdformat10' ]
-def sdformat_gz11_branches = [ 'sdformat8', 'sdformat9', 'sdformat10', 'master' ]
+def sdformat_supported_branches = [ 'sdformat4', 'sdformat6', 'sdformat9', 'sdformat10' ]
+def sdformat_gz11_branches = [ 'sdformat9', 'sdformat10', 'master' ]
 // nightly and prereleases
 def extra_sdformat_debbuilder = [ ]
 

@chapulina chapulina marked this pull request as ready for review January 4, 2021 16:38
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

I think we can disable CI for sdformat8 as well

225e643

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a dependencies_archive clean up. It probably needs a bit more to be fully updated but the changes should reflect modifications of this PR. I would like a quick double check on that commit and a bit of testing since changes in that file potentially affect many different builds.

jenkins-scripts/lib/dependencies_archive.sh Show resolved Hide resolved
@chapulina
Copy link
Contributor Author

I would like a quick double check on that commit

It looks good to me 馃憤

Merging

@chapulina chapulina merged commit 2ba8e93 into master Jan 5, 2021
@chapulina chapulina deleted the chapulina/blueprint/eol branch January 5, 2021 00:14
@chapulina chapulina mentioned this pull request Dec 21, 2021
36 tasks
@chapulina chapulina mentioned this pull request Mar 8, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants