Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuelClient.cc: include <deque> #213

Merged
merged 4 commits into from Nov 8, 2021
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 6, 2021

🦟 Bug fix

Fixes the Windows build.

Summary

The std::deque datatype was used in #199, but the Windows compiler seems to have trouble identifying the datatype. Seems like a missing header.

Build Status https://build.osrfoundation.org/job/ign_fuel-tools-ign-4-win/8/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Fixes the Windows build.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Nov 6, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #213 (821f8da) into ign-fuel-tools4 (c680ee8) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #213      +/-   ##
===================================================
- Coverage            77.92%   77.90%   -0.03%     
===================================================
  Files                   19       19              
  Lines                 2718     2715       -3     
===================================================
- Hits                  2118     2115       -3     
  Misses                 600      600              
Impacted Files Coverage Δ
src/FuelClient.cc 73.23% <ø> (ø)
src/ign.cc 57.40% <ø> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c680ee8...821f8da. Read the comment docs.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented Nov 7, 2021

the windows test is failing due to a console error message introduced in #199 ( #199 (comment) ), but I believe this should fail on all platforms. I think the redirectIO helper function in that test is broken on some platforms, so I opened #214

This was introduced in #199.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Core development automation moved this from Inbox to In review Nov 7, 2021
@mjcarroll mjcarroll merged commit 4edeed5 into ign-fuel-tools4 Nov 8, 2021
@mjcarroll mjcarroll deleted the scpeters/include_deque branch November 8, 2021 13:37
Core development automation moved this from In review to Done Nov 8, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants