use qmldir to define QML module with IgnSpinBox #319
Conversation
There was a problem hiding this comment.
Nice, thank you for cleaning it up!
The approach looks good to me. I also checked that import "qrc:/qml" still works, so this doesn't break any existing users.
Would you be able to retarget this PR to ign-gui3? Then we can merge it forward to all supported versions from there.
Thanks!
Signed-off-by: William Wedler <william.wedler@resquared.com>
Signed-off-by: William Wedler <william.wedler@resquared.com>
I branched off of |
chapulina
added
馃彴 citadel
zflat
force-pushed
the
qml_modules
branch
3 times, most recently
from
63f8ac0
to
908ae31
Compare
Signed-off-by: William Wedler <william.wedler@resquared.com>
|
@chapulina Are there any more QML components that should be added to the
Or should additional components be added in a separate pull request? |
I was thinking about that. The only one that we really use downstream is There's been conversations about adding generic widgets for pose, vector, etc, which we repeat a lot in |
Signed-off-by: William Wedler <william.wedler@resquared.com>
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <nikhilnicky972@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <william.wedler@resquared.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com> * Fix codecheck (#329) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix codecheck (#332) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nikhil Nair <43491351+NickNair@users.noreply.github.com> Co-authored-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Will <1305536+zflat@users.noreply.github.com> Co-authored-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
馃帀 New feature
Closes #310
Summary
This change adds a qmldir file that defines an importable QML module for common QML components implemented in
include/ignition/gui/qml/.With this change, it will be possible to import QML components using module import statements instead of file path.
Updating import statements will look like this:
Test it
ign runIgnSpinBoxis part of the UIChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge