Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frustrum Python interface #278

Merged
merged 6 commits into from Nov 12, 2021
Merged

Frustrum Python interface #278

merged 6 commits into from Nov 12, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 29, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added Frustrum Python interface.

It depends on #272

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 29, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Oct 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 29, 2021
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 29, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Oct 29, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #278 (4305560) into ign-math6 (919b511) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #278   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919b511...4305560. Read the comment docs.

@scpeters scpeters changed the title Added Frustrum Python interface Frustrum Python interface Nov 12, 2021
@scpeters
Copy link
Member

minor whitespace fix in 4305560

@ahcorde ahcorde merged commit 5201e53 into ign-math6 Nov 12, 2021
Core development automation moved this from In review to Done Nov 12, 2021
@ahcorde ahcorde deleted the ahcorde/python/frustrum branch November 12, 2021 08:42
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants