Added fixed and revolute joints (Ignition -> issacsim) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
* Some fixed to thread safe arch Signed-off-by: ahcorde <ahcorde@gmail.com> * Include PIMPL and model name should not constain spaces Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
koonpeng
approved these changes
Feb 27, 2022
| @@ -361,6 +361,175 @@ bool Scene::Implementation::UpdateJoint(const ignition::msgs::Joint &_joint) | |||
| auto stage = this->stage->Lock(); | |||
| auto jointUSD = | |||
| stage->GetPrimAtPath(pxr::SdfPath("/" + worldName + "/" + _joint.name())); | |||
| if (!jointUSD) | |||
There was a problem hiding this comment.
Is this the same code from sdformat, if so should we add a TODO just to keep track of duplicated code which we should re-use in the future when it's possible to do so?
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Summary
Added fixed and revolute joints (Ignition -> issacsim)
Test it
Launch this model https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Panda%20with%20Ignition%20position%20controller%20model
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.