-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added textures support to threadsafe branch #9
Conversation
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Some fixed to thread safe arch Signed-off-by: ahcorde <ahcorde@gmail.com> * Include PIMPL and model name should not constain spaces Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Teo Koon Peng <koonpeng@openrobotics.org>
…readsafe-material
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I didn't manage to test this, can you point me to a sdf/model with textures to test this?
Signed-off-by: ahcorde <ahcorde@gmail.com>
You can try this PR with this model from fuel https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Depot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
Added texture support to thread-safe branch.
we are copying the images into nucleus, maybe we should use a better name for the texture paths. we can join the name of the model for example. what do you think @koonpeng ?
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.