Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpplint (fix argument name in ci.yml) #41

Merged
merged 1 commit into from Mar 1, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 1, 2022

馃 Bug fix

Argument to enable cpplint was incorrect

Summary

Enable cpplint

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner March 1, 2022 22:08
@github-actions github-actions bot added 馃尡 garden Ignition Garden 馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress labels Mar 1, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Mar 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #41 (09da0c5) into ign-utils1 (f8a5c4f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           ign-utils1      #41   +/-   ##
===========================================
  Coverage       94.87%   94.87%           
===========================================
  Files               5        5           
  Lines              78       78           
===========================================
  Hits               74       74           
  Misses              4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f8a5c4f...09da0c5. Read the comment docs.

Core development automation moved this from Inbox to In review Mar 1, 2022
@chapulina chapulina merged commit c7c4a54 into ign-utils1 Mar 1, 2022
@chapulina chapulina deleted the scpeters/enable_cpplint branch March 1, 2022 22:37
Core development automation moved this from In review to Done Mar 1, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress 馃尡 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants