Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to Migration guide #630

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes a minor error in the Migration guide.

Summary

This is a very minor error, but I wanted to test gazebo-tooling/release-tools#493, so I decided to open this PR. I'm going to push another change quickly to see if the first round of CI is cancelled automatically.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 22, 2021
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters scpeters marked this pull request as ready for review July 22, 2021 19:05
@scpeters scpeters added this to Inbox in Core development via automation Jul 22, 2021
@scpeters scpeters moved this from Inbox to In review in Core development Jul 22, 2021
@scpeters scpeters merged commit 3a8d345 into gazebosim:sdf9 Jul 22, 2021
Core development automation moved this from In review to Done Jul 22, 2021
@scpeters scpeters deleted the migration_fix_9 branch July 22, 2021 22:25
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants