Added comment reminder to update functions #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## sdf9 #677 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 62 62
Lines 9734 9734
=======================================
Hits 8453 8453
Misses 1281 1281
Continue to review full report at Codecov.
|
azeey
reviewed
Aug 26, 2021
include/sdf/Param.hh
Outdated
| @@ -244,6 +244,8 @@ namespace sdf | |||
|
|
|||
| /// \def ParamVariant | |||
| /// \brief Variant type def. | |||
| /// TODO(anyone) When a new variant is added, add variant to functions | |||
There was a problem hiding this comment.
I would think just a Note would be enough since there's nothing to do in its current state.
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a
TODOcomment to updateParamPrivate::TypeToStringandParamPrivate::ValueFromStringImplfunctions when newParamVariantis added.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge