-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added comment reminder to update functions #677
Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #677 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 62 62
Lines 9734 9734
=======================================
Hits 8453 8453
Misses 1281 1281
Continue to review full report at Codecov.
|
include/sdf/Param.hh
Outdated
@@ -244,6 +244,8 @@ namespace sdf | |||
|
|||
/// \def ParamVariant | |||
/// \brief Variant type def. | |||
/// TODO(anyone) When a new variant is added, add variant to functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think just a Note
would be enough since there's nothing to do in its current state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Summary
Added a
TODO
comment to updateParamPrivate::TypeToString
andParamPrivate::ValueFromStringImpl
functions when newParamVariant
is added.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge