-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #721 to sdf9: Make exception for plugins when checking for name uniqueness #733
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…im#721) Adds an exception for the <plugin> element so that no warning is emitted when a plugin name matches the names of other entities. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #733 +/- ##
==========================================
- Coverage 86.88% 86.83% -0.05%
==========================================
Files 62 62
Lines 9734 9756 +22
==========================================
+ Hits 8457 8472 +15
- Misses 1277 1284 +7
Continue to review full report at Codecov.
|
@osrf-jenkins run tests please |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Backport
Summary
Backport #721 to sdf9.
Builds on #731
In addition, I've backported code for console redirection from
sdf11
in 8e1d5e5Note to maintainers: Remember to use Squash-Merge