New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support URI in the Model DOM #786
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #786 +/- ##
==========================================
+ Coverage 89.53% 89.56% +0.03%
==========================================
Files 76 76
Lines 12585 12603 +18
==========================================
+ Hits 11268 11288 +20
+ Misses 1317 1315 -2
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: Nate Koenig nate@openrobotics.org
馃帀 New feature
Summary
The SdfGenerator code in Ignition Gazebo has a map that associates URIs to models. In order to use the DOM to generate SDF with model
<include>
elements we need a way to set a model's URI and use the URI in theToElement
function.This PR support setting a model's URI, and updates the ToElement to use the URI. This won't break ABI because the
Model::ToElement
has not been released.Test it
Run the tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge