Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting Design from grin.ninja #4

Merged
merged 1 commit into from Oct 31, 2018
Merged

Adopting Design from grin.ninja #4

merged 1 commit into from Oct 31, 2018

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Oct 31, 2018

This PR implements a design from grin.ninja - https://hq.grin.ninja/ as a Jekyll theme.
Caveats:

  • Not a whole lot is now can be configurable from *.yml files. I decided that we can go incrementally on this.
  • On pages, like learn and funding "Home" link would appear and would lead to /. It means that it would work on example.com, but not on example.com/super-site/. Not sure how to fix it for now.

The preview of the website is here: https://i1skn.github.io/site-test/.
Although, only differences from the https://hq.grin.ninja/ are:

@ignopeverell
Copy link
Owner

@i1skn this is great! I agree on making this a little more incremental. Would you prefer leaving this PR open for these improvements and potential @JollyGrin design improvements as well or do you prefer progressing with additional PRs?

@i1skn
Copy link
Contributor Author

i1skn commented Oct 31, 2018

I think it's better to proceed with additional PRs:

  • People would see the text they editing right on the new design.
  • Bugs/missing features would be found faster because more users would see/play with it.

@ignopeverell @JollyGrin What do you think?

@ignopeverell ignopeverell merged commit cfe28ed into ignopeverell:master Oct 31, 2018
@ignopeverell
Copy link
Owner

Merged!

@JollyGrin
Copy link

Sounds good to me! I'll continue making any design improvements on hq.grin.ninja for simplicity sake, but as you said could me added with additional pull requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants