New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong function type for generateCalendar #28

Open

zhkjim opened this issue May 17, 2023 · 1 comment

zhkjim commented May 17, 2023

https://github.com/igor-ribeiro/calendar-js/blob/15bf0f4e079fb1355b4dddf318d0a161d4d09eda/index.d.ts#LL27C3-L27C3

generateCalendar: function(
year,
month,
numberOfDays,
firstWeekday,
lastWeekday,
dayTransformer,
cbData
)

Owner

igor-ribeiro commented May 22, 2023

Hey, thanks for reporting it. Yeah, it's pretty rough, I'm planning on rewriting this project.

For now, I pushed a beta version with the fix, could you test it with 1.4.6-beta.0?

igor-ribeiro added a commit that referenced this issue


          fix(types): generateCalendar interface #28

0f09191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment