Skip to content

Commit

Permalink
googleapis#12: fix incorrectly checked value of request parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
igor-solomatov committed Feb 2, 2021
1 parent 16e7294 commit 9ca3c2e
Show file tree
Hide file tree
Showing 73 changed files with 533 additions and 533 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def aggregated_list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -197,7 +197,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -252,7 +252,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down
10 changes: 5 additions & 5 deletions google/cloud/compute_v1/services/addresses/transports/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def aggregated_list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -218,7 +218,7 @@ def delete(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -297,7 +297,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -381,7 +381,7 @@ def insert(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -435,7 +435,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down
14 changes: 7 additions & 7 deletions google/cloud/compute_v1/services/autoscalers/transports/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def aggregated_list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -218,7 +218,7 @@ def delete(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -290,7 +290,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -374,7 +374,7 @@ def insert(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -431,7 +431,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -516,7 +516,7 @@ def patch(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -601,7 +601,7 @@ def update(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def add_signed_url_key(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -247,7 +247,7 @@ def delete(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -329,7 +329,7 @@ def delete_signed_url_key(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -386,7 +386,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -470,7 +470,7 @@ def insert(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -527,7 +527,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -613,7 +613,7 @@ def patch(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -699,7 +699,7 @@ def update(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def add_signed_url_key(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -224,7 +224,7 @@ def aggregated_list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -305,7 +305,7 @@ def delete(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -387,7 +387,7 @@ def delete_signed_url_key(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -460,7 +460,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -517,7 +517,7 @@ def get_health(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -601,7 +601,7 @@ def insert(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -658,7 +658,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -744,7 +744,7 @@ def patch(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -831,7 +831,7 @@ def set_security_policy(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -917,7 +917,7 @@ def update(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def aggregated_list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -207,7 +207,7 @@ def get(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down Expand Up @@ -261,7 +261,7 @@ def list(
# discards default values
# TODO(yon-mg): add test for proper url encoded strings
query_params = [
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
]
url += "?{}".format("&".join(query_params)).replace(" ", "+")

Expand Down

0 comments on commit 9ca3c2e

Please sign in to comment.