Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select method changes and docs #32

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Conversation

igorbenav
Copy link
Owner

Pull Request Template for FastCRUD

Description

This is essentially a bug fix + docs for #28 by @dubusster

Changes

  • bug fix
  • docstring enhanced
  • docs added both in usage and advanced

Tests

  • more tests
  • tests reformatted to multiple functions

Detailed Bug Fix

In select, checking whether sort_columns are provided were written as follows:

if "sort_columns":
           stmt = self._apply_sorting(stmt, sort_columns, sort_orders)

Which was fixed to:

if sort_columns:
           stmt = self._apply_sorting(stmt, sort_columns, sort_orders)

@igorbenav igorbenav added bug Something isn't working documentation Improvements or additions to documentation labels Mar 21, 2024
@igorbenav
Copy link
Owner Author

Hey, @dubusster, do you want to take a look?

@dubusster
Copy link
Contributor

Oups, thanks for the fix and the additional tests @igorbenav!

@dubusster
Copy link
Contributor

I'll have a look tomorrow to maybe add some more detailed tests

Copy link
Contributor

@dubusster dubusster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also missed some typing in fast_crud.py

fastcrud/crud/fast_crud.py Outdated Show resolved Hide resolved
@igorbenav igorbenav merged commit 7ace2da into main Mar 23, 2024
10 checks passed
@igorbenav igorbenav deleted the select-method-changes-and-docs branch March 23, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants