Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize pos_to_line_col() calculation for big input data #131

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Conversation

xor2003
Copy link

@xor2003 xor2003 commented Jan 24, 2021

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

@coveralls
Copy link

coveralls commented Jan 24, 2021

Coverage Status

Coverage increased (+0.1%) to 91.172% when pulling 9dc3f72 on xor2003:master into 04bb549 on igordejanovic:master.

@igordejanovic igordejanovic merged commit 9dc3f72 into igordejanovic:master Jan 24, 2021
@igordejanovic
Copy link
Owner

@xor2003 Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants