Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to call semantic actions while building parse tree #45

Merged
merged 4 commits into from
May 28, 2018
Merged

Option to call semantic actions while building parse tree #45

merged 4 commits into from
May 28, 2018

Conversation

alensuljkanovic
Copy link
Contributor

Enhancement implemented as discussed in the #44 .

@alensuljkanovic
Option to call semantic actions while building AST
f433e1b 
For more info check:
igordejanovic#44
@alensuljkanovic
Rename parameter and refactor code
4edc90d 
Parameter `call_actions` renamed to `call_actions_during_tree_build`
for better understanding.

Refactored return value code to ecape subtle bugs.
@alensuljkanovic
Add docs for new parser parameter
47fd163 
Added docs for `call_actions_during_tree_build` parser parameter.
@alensuljkanovic
Add test for call_actions_during_tree_build
9199563
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 85.617% when pulling 9199563 on alensuljkanovic:sem-actions-on-build-tree into 204e239 on igordejanovic:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 85.617% when pulling 9199563 on alensuljkanovic:sem-actions-on-build-tree into 204e239 on igordejanovic:master.

@coveralls
Copy link

coveralls commented May 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 85.617% when pulling 9199563 on alensuljkanovic:sem-actions-on-build-tree into 204e239 on igordejanovic:master.

@igordejanovic
Copy link
Owner

Looks good. Merging. Thanks!

@igordejanovic igordejanovic merged commit 0ccf259 into igordejanovic:master May 28, 2018
@igordejanovic igordejanovic mentioned this pull request May 28, 2018
Closed
@jwcraftsman jwcraftsman mentioned this pull request Jul 17, 2018
Open
@jwcraftsman jwcraftsman mentioned this pull request Jul 24, 2018
Open
jwcraftsman added a commit to jwcraftsman/parglare that referenced this pull request Jul 27, 2018
@jwcraftsman
Reverted pull request igordejanovic#45.
bb1cae5
@jwcraftsman jwcraftsman mentioned this pull request Aug 1, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alensuljkanovic @coveralls @igordejanovic