Refactor after Composable discussions. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscription to the list of tasks updated from a hot to a cold flow. This way we avoid leaking the data and unnecessary data loads when the user is in other screen/composable.
Subscription to the list of tasks updated from a hot to a cold flow. This way we avoid leaking the data and unnecessary data loads when the user is in other screen/composable.
Subscription to the list of tasks updated from a hot to a cold flow. This way we avoid leaking the data and unnecessary data loads when the user is in other screen/composable.
The older names did not represent the idea of creating a flow of states. Names were updated to reflect so.
In order to avoid multiple calls to the Flow<*State>, now it is remembered inside the @composable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a great discussion in kotlinlang Slack, some refactor were made to update the hot flows to cold flows, giving more lifecycle control and avoiding multiple recompositions in different screens.
Special thanks to @adamp.