🎨 Add Navigation Rail to Home Composable #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new dependency was added to easily handle different form factors in Compose
Since we might need the form factor information across different Composables, now is a good time to have a dedicated state class. This approach follows the implementation on Now In Android.
Alkaa now supports different form factors properly! The NavigationRail will be shown when appropriate thanks to the WindowSizeClass and the boilerplate from Now In Android.
Now that we have UI changes, this changes must reflect on the Instrumented tests. Also, a new WindowSizeClassFake was created to simulate the device density. In the future, more tests with different densities will be added.
In the original concept, this BowWithConstraints would show two columns when the app is on landscape or bigger screens. However, it does not work very well. When the keyboard opens it show two columns, creating a very bad UX. This is gone for now and will be improved in future commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some initial efforts on #225, now it's time for Alkaa to properly support different form factors. The first step is implementing a NavigationRail to better accommodate the navigation icons on the screen.
The next PRs improve the experience by using multiple panes and better using the empty space on the screen.
This implementation was based on the Now In Android repo by @android.