Fix Bottom Nav colors not updating after theme change #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorescodro
changed the title
igorescodro
changed the title
This file was all alone in the root of preference module. Now it is where it belongs.
Previously we had a better user experience by not allowing that. If the user clicks on the dialog and just want to dismiss it, they need to click on the same item again. Now it's possible to dismiss it like any other regular dialog.
When updating the system theme under the Preference screen, the colors in the Bottom Nav would remain the previous one until the app recomposes. It's weird because the theme change is trigger the high level recomposition and updating all subsequent components. The solution for this issue was to remove the custom colors from `NavigationBarItem` and use the default ones. Now that this component is Material3 it will get the correct colors without additional setup. This fix both the issue and the UI that sometimes was not beautiful because of weird colors.
igorescodro
force-pushed
the
fix-app-theme
branch
from
491fbb6
to
bb0a83c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the system theme under the Preference screen, the colors in the Bottom Nav would remain the previous one until the app recomposes. It's weird because the theme change triggers the high-level recomposition and updates all subsequent components.
The solution for this issue was to remove the custom colors from
NavigationBarItemand use the default ones. Now that this component is Material3 it will get the correct colors without additional setup. This fix both the issue and the UI that sometimes was not beautiful because of weird colors.Also, the UX was improved by allowing dismiss on clicking outside the dialog. Previously, if the user clicks on the dialog and just wants to dismiss it, they need to click on the same item again.