Added Jetpack Glance Theming #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlkaaGlanceTheme provides the glance theme,its used to get the dynamic colors,providing the color-provider by ColorProviders on Android 12+ dynamic color is taken in using material3 glance dependency and below that designed system colors. Under Android 12 glance docent provides corner radius thus a shape drawable with the similar color radius is implemented with surface colors. Additionally due to the theme change preview is not properly visible in the widget drawer so added surface and surface color values For No task additional vector resource is used to designate there is no tasks. The heading of the widget was looking blank so added the Heading "Your Tasks",for the portuguese I just googled the translation,please change them if they are wrong. TaskListGlanceWidget changes are added, changes include use of GlanceTheme.colors provider as color provider and some others. In loading and preview added the background which is the same drawable mentioned above
The app widget can be directly updated by using updateAll no need to use the updateAppWidget when the serializer data get updated the update is catch by the currentState. A updateData function that takes the new data and update the serializer
|
It's seems due to the keytool the build is failing.Its showing keystore was tampered with or password was incorrect.Could you elaborate on this.(why the build is failing) |
The current CI structure is not very fork friendly. The I'll try to update the CI to run with fake credentials when an external PR is submitted, but this might take a while. In the meantime, I recommend you run |
AlkaaGlanceTheme provides the glance theme,its used to get the dynamic colors,providing the color-provider by ColorProviders on Android 12+ dynamic color is taken in using material3 glance dependency and below that designed system colors. Under Android 12 glance docent provides corner radius thus a shape drawable with the similar color radius is implemented with surface colors. Additionally due to the theme change preview is not properly visible in the widget drawer so added surface and surface color values For No task additional vector resource is used to designate there is no tasks. The heading of the widget was looking blank so added the Heading "Your Tasks",for the portuguese I just googled the translation,please change them if they are wrong. TaskListGlanceWidget changes are added, changes include use of GlanceTheme.colors provider as color provider and some others. In loading and preview added the background which is the same drawable mentioned above
The app widget can be directly updated by using updateAll no need to use the updateAppWidget when the serializer data get updated the update is catch by the currentState. A updateData function that takes the new data and update the serializer
|
Awesome! Now it’s working properly. The CI is failing due to lint checks. I believe you are good to go. Unfortunately, the Instrumented Tests are very flaky recently so I might need to rerun them a few times. |
… glance-changes
|
Great to hear that the workflows are working fine now! |
AlkaaGlanceTheme provides the glance theme,its used to get the dynamic colors,providing the color-provider by ColorProviders on Android 12+ dynamic color is taken in using material3 glance dependency and below that designed system colors. Under Android 12 glance docent provides corner radius thus a shape drawable with the similar color radius is implemented with surface colors. Additionally due to the theme change preview is not properly visible in the widget drawer so added surface and surface color values For No task additional vector resource is used to designate there is no tasks. The heading of the widget was looking blank so added the Heading "Your Tasks",for the portuguese I just googled the translation,please change them if they are wrong. TaskListGlanceWidget changes are added, changes include use of GlanceTheme.colors provider as color provider and some others. In loading and preview added the background which is the same drawable mentioned above
The app widget can be directly updated by using updateAll no need to use the updateAppWidget when the serializer data get updated the update is catch by the currentState. A updateData function that takes the new data and update the serializer
Most of the linting errors are corrected. Some doc strings are added and some where its corrected. In the glance app preview the new glance heading <Your Tasks> aren't added so updated the preview xml and preview png files.
Ktlint was containing about the some linting problems fixed that. The actual code is not changed only commas and braces are added
Reverting file that was wrongly updated when rebasing
Dumb mistake
igorescodro
reviewed
Aug 21, 2023
features/glance/src/main/java/com/escodro/glance/presentation/TaskListGlanceWidget.kt
Outdated
Show resolved
Hide resolved
String resources for portuguese is corrected as per the suggestions,added contentDescription for Images
|
Changes as per the suggestion
|
igorescodro
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Colors to App Widget
App Widget is now responsive to the dynamic colors of the app on Android 12+,on lower version the app light and dark theme is used.
Secondary Changes