🚦 Implement KMP navigation #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing navigation module was revamped to be a KMP module and starting using Voyager as the navigation framework. For now, only the Task and Category flows were added. Future changes will add the remaining ones and also we will investigate if it's worth it to move the tab navigation to this library too. Since the module was an Android library and still referenced, everything was commented at this moment.
In order to make sure that iOS will keeping running, all the Interactors that are not implemented will be disabled. In the future, a more scalable solution will be implemented to handle both the cases where iOS will have a dedicated implementation and also the ones that should be ignored.
Screen related to the Task feature were ported to the Voyager setup
Screen related to the Category feature were ported to the Voyager setup
The Home feature was updated to be more aligned with the new navigation system
The Shared feature was updated to be more aligned with the new navigation system
More code was commented to make the code compile. Future changes will simply remove this legacy NavGraph entirely.
As expected, a few things were reported and fixed
When doing some changes in the code structure, some stuff were broken. Fixed.
igorescodro
force-pushed
the
kmp/navigation
branch
from
392e8c7
to
432b51f
Compare
Temporary solution to fix domain the unit tests. Since the Notification, Alarm and Widget/Glance features are not ported to KMM, the DI will provide a nullable injection for those Interactors. Unfortunately, Koin does not support `getOrNull` with the Constructor DSL so we are back to the ugly injection temporarily.
igorescodro
merged commit 4e8c861
into
alkaa-compose-multiplatform
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving away from AndroidX Navigation to Voyager. Much easier than I though and very similar to Koin APIs and DSLs.