🗑️ Remove the Android navigation system #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have this on KMP modules, let's kill the old navigation system with fire!
Some dependencies are no longer needed in the app's build.gradle since the :shared module is responsible for connecting everything together. Also, some Compose dependencies were removed from the dependencies file to clean-up.
igorescodro
force-pushed
the
kmp/clean-up
branch
from
b8e6609
to
5aa3372
Compare
Having multiple crossfade effects when the device is in dark theme created a white flick in between. Removing the crossfade from the tabs and relying in the ones on each screen state to create a smoother animation.
Removing redundant action holder class now that we have Voyager to handle these interactions without hoisting everything.
Now that we have platform specific injections, it's harder to make sure that all injections are there. Will investigate if there's a better way to inject and test those injections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AndroidX Navigation was removed now that everything is ported to KMP, using Voyager. Some clean-up on the
build.gradleandlibs.versions.tomlalso made.