Rails 5.2 attachement purge on content type invalidation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the 'file purge on content type invalidation' test pass, but makes an apparently unrelated test (Matchers::SizeValidatorMatcher) fail. This commit should not be merged, and is here only as an example
|
closing this for now, I think it's not a part of validator, and issue is fixed in newer rails versions as I understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following the #55 issue, here are 2 commits to get started:
.purgein a controller), but as mentioned in the issue, it apparently messes up the validation callbacks. In this case, this messes up another seemingly unrelated test. You can use it to see where it fails, but another solution seems to be necessary. So this 2nd commit is just an example.I'm still a beginner, so I hope this isn't too 'dirty'. Also, I would love to know your solution to this problem :)