New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuration for optional (armbian tool) local ccache #464 #466
Conversation
update master 20160717 #1
update master 20160718
Added fswebcam-gc2035 package
update master 20160720
update master 20160721
update master 20160723
update master 20160724
update master 20160725
update master 20160729
Small cleanup
update master 20160731
update master 20160802
update master 20160803
update master 20160806
update master 20160810
update master 20160811
update master 20160813
update master 20160815
update master 20160815 #2
update master 20160816
update master 20160821
update master 20160823
update master 20160825
update master 20160901
update master 20160908
update master 20160910
update master 20160911
update master 20160912
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other part of that change look good. Let's see what others say...
@@ -31,6 +31,12 @@ FORCE_CHECKOUT="yes" # ignore manual changes to source | |||
BUILD_ALL="no" # cycle through available boards and make images or kernel/u-boot packages. | |||
# set KERNEL_ONLY to "yes" or "no" to build all packages/all images | |||
|
|||
PRIVATE_CCACHE="no" # Use separate ccache directory located in build tree ($DEST/ccache) | |||
# Can be used to avoid problems with ownershipt on $HOME/.ccache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ownership of
PRIVATE_CCACHE="no" # Use separate ccache directory located in build tree ($DEST/ccache) | ||
# Can be used to avoid problems with ownershipt on $HOME/.ccache. | ||
# Set to "yes" if you are using build script as non-root user with "sudo" | ||
# note: to use a ramdisk for ccache, create first a symlink to $DEST/ccache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first create
# Can be used to avoid problems with ownershipt on $HOME/.ccache. | ||
# Set to "yes" if you are using build script as non-root user with "sudo" | ||
# note: to use a ramdisk for ccache, create first a symlink to $DEST/ccache | ||
# Set to "no" check if $DEST/ccache exists and delete (directory/symlink) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. It will automagically delete $dest/ccache and then use $home/.ccache ? I'll let the user do the cleanup himself, eventually printing a message that "there's a trailing ccache directory at $dest/ccache" because he may still want to use it later or he made the mistake to change the variable, or whatever. The content may be worth hours of compilation...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exactly, the default config for ccache is $HOME/.ccache (here it is PRIVATE_CCACHE="no")
with PRIVATE_CCACHE="yes", you can have a ccache folder limited to Armbian tool usage.
Armbian tool creates "root" owned files in $HOME/.ccache (this is somewhat ugly)
I was in trouble ccache-compiling other softwares as "non-root" user so I guess the Armbian tool should clean its own mess
Moreover, (with more changes) it would offer the possibility to create ccache per SoC for mass compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and yes, it will delete $DEST/ccache if it exists when PRIVATE_CCACHE="no" to switch back to $HOME/.ccache
In my opinion, if a tool creates mess (root owned files in $HOME/.ccache) it is better to offer the option to deal/avoid the mess by design (and not by luck/goodwill/etc.) so having a separate folder for ccache is a good option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and btw, I am French :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand the "need" for that cleanup, even if a bit unfortunate...
But untangling the need for running as "root" would be a bigger task, so I retract my objection.
LGTM with the other small glitches fixed...
PS: I'm also french (from Alsace)
update master 20160917
update master 20160919
update from master 20160920
update master 20160920/2
Implemented in 870a7ac |
proposal for enhancement #464