Observer can now be extended #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski
commented
Jan 31, 2018
| @@ -133,3 +133,4 @@ solving of bugs, etc.) from the following developers : | |||
| * Koert Gaaikema (@koertgaaikema) | |||
| * Matt Logan (@mattlogan) | |||
| * Aran Arunakiri | |||
| * @rckrdstrgrd | |||
There was a problem hiding this comment.
Credit where credit is due :)
igorski
commented
Jan 31, 2018
| void handleNotification( int aNotificationType ); | ||
| void handleNotification( int aNotificationType, int aValue ); | ||
| virtual void handleNotification( int aNotificationType ); | ||
| virtual void handleNotification( int aNotificationType, int aValue ); | ||
| }; |
There was a problem hiding this comment.
Functions can now be overridden by inheriting classes.
igorski
commented
Jan 31, 2018
| delete aEvent; | ||
| aEvent = 0; | ||
| delete audioEvent; | ||
| audioEvent = 0; | ||
| #endif |
There was a problem hiding this comment.
If you're going to clear memory, do it on properties that actually exist, yo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring Observer can be extended as an C++ class, also fixing some bugs by observation (punny). Both cases noted by @rckrdstrgrd